Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't support empty quotes #12

Closed
JamesMessinger opened this issue Mar 10, 2019 · 0 comments
Closed

Doesn't support empty quotes #12

JamesMessinger opened this issue Mar 10, 2019 · 0 comments

Comments

@JamesMessinger
Copy link
Contributor

An empty pair of quotes (e.g. "") should pass an empty string argument. But string-argv currently passes the actual quote characters instead.

STEPS TO REPRODUCE

$ node
> var stringArgv = require('string-argv');
undefined
> stringArgv('git commit --message ""')

EXPECTED RESULTS

[ 'git', 'commit', '--message', '' ]        // <--- Last arg is an empty string

ACTUAL RESULTS

[ 'git', 'commit', '--message', '""' ]      // <--- Last arg is two quotes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant