Bug: Account syncing notification behaviour

[justinfar]

Describe the bug
The behaviour of the notification when trying to sync accounts is a bit erratic as it resizes in width a few times, and just shows multiple Sync complete notifications until timing out before the success message can be even read.

A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. Go to Settings/Accounts
2. Click on Sync All
3. See notification stack and quick timeout

Expected behavior

1. Click Sync
2. A single notfication is shown where the state changes from Syncing account balances to Syncing complete/failed (depending on state)

What version of Maybe are you using?
Hosted" (i.e. app.maybe.co)

Screenshots / Recordings
https://github.com/user-attachments/assets/2c653863-9d25-4dfc-a0e6-bd4e80020638

[zachgoll]

For anyone looking into this, here are the relevant lines that trigger the Turbo Stream updates during the sync:

maybe/app/models/account/sync.rb

Lines 62 to 81 in 45935db

	def broadcast_start
	broadcast_append_to(
	[ account.family, :notifications ],
	target: "notification-tray",
	partial: "shared/notification",
	locals: { id: id, type: "processing", message: "Syncing account balances" }
	)
	end
	def broadcast_result(type:, message:)
	broadcast_remove_to account.family, :notifications, target: id # Remove persistent syncing notification
	broadcast_append_to(
	[ account.family, :notifications ],
	target: "notification-tray",
	partial: "shared/notification",
	locals: { type: type, message: message }
	)
	account.family.broadcast_refresh
	end

[Awlter]

I have checked the code, it seems it's more of a design issue. What's the ultimate expected behavior after clicking the sync all button?

[zachgoll]

#1433 introduces a new way of syncing and should eliminate this issue, so I'm going to close this out to avoid merge conflicts.