Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TicTacToe] Add tests #3

Open
mattiadg opened this issue Oct 8, 2018 · 7 comments
Open

[TicTacToe] Add tests #3

mattiadg opened this issue Oct 8, 2018 · 7 comments
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest Nice PR for Hacktoberfest

Comments

@mattiadg
Copy link
Owner

mattiadg commented Oct 8, 2018

Unit tests and game tests are required. It is useful to learn about test tools in C++.

@mattiadg mattiadg added enhancement New feature or request good first issue Good for newcomers Hacktoberfest Nice PR for Hacktoberfest labels Oct 8, 2018
@mattiadg mattiadg changed the title Tests for TicTacToe [TicTacToe] Add tests Oct 8, 2018
@Pansaai
Copy link
Contributor

Pansaai commented Oct 14, 2018

Is there a certain testing framework that should be used, or anything would do ?

I have never done this before but i would like to play around with it and try to implement this.

@mattiadg
Copy link
Owner Author

I have never used testing frameworks for C++. So, if there are some that you find interesting, we can choose among them.

@Pansaai
Copy link
Contributor

Pansaai commented Oct 14, 2018

Well i have been looking around and this is what i found.

  • Catch2: Header only, easy to start but doe not support mock objects

  • Google test: mocking out of the box and supports death tests. Is a little heavier though and needs to be embedded.

I would personally like to have a look at google test as this is also the one where I can find the most documentation.

@mattiadg
Copy link
Owner Author

mattiadg commented Oct 14, 2018 via email

@mattiadg mattiadg assigned mattiadg and unassigned mattiadg Oct 14, 2018
@Pansaai
Copy link
Contributor

Pansaai commented Oct 17, 2018

Just quick update after a few days of messing around.

I think catch2 will be the best choice here, it is really straight forward.

google test was just a pain to setup and integrate.

@mattiadg If you agree i will continue with catch2 as the testing framework

@mattiadg
Copy link
Owner Author

mattiadg commented Oct 18, 2018 via email

@Pansaai Pansaai mentioned this issue Oct 30, 2018
@mattiadg
Copy link
Owner Author

mattiadg commented Nov 3, 2018

Addressed in #26. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest Nice PR for Hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants