Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

position resets after adding an extra :hover animation #163

Closed
ryjogo opened this issue Mar 6, 2015 · 5 comments
Closed

position resets after adding an extra :hover animation #163

ryjogo opened this issue Mar 6, 2015 · 5 comments

Comments

@ryjogo
Copy link

ryjogo commented Mar 6, 2015

I'm adding an extra :hover to my class,
however it fires off, but resets automatically when finshed.

(Example scss)

.nudge-up {
  @include transition(transform .2s ease-in-out);
  &:hover {
    @include transform(translate(0px, -5px));
  }
}

i wish for it to stick until i loose focus, when i remove my WOW js init, this is the desired behavour.

@ryjogo
Copy link
Author

ryjogo commented Mar 6, 2015

ok, i've solved my problem, could this be considered a bug?

.nudge-up {
  @include transition(transform .2s ease-in-out);
  &:hover {
    @include animation(0);
    @include transform(translate(0px, -5px));
  }
}

should it automatically stop any animations after finished? or would this be an animate.css issue?

@mdeboer
Copy link
Contributor

mdeboer commented Mar 17, 2015

Afaik it's a WOW 'issue' as it doesn't remove the animated class once the animation is complete. For now use your fix, I'll see if I can fix this and I'll do a pull request.

Would you mind giving it a spin when I fixed it? 👍

@ryjogo
Copy link
Author

ryjogo commented Mar 17, 2015

ok thansk, and of course :)

@mdeboer
Copy link
Contributor

mdeboer commented Mar 17, 2015

@modstudio please see my pull request #164. Should have fixed your issue. I tried removing the animated class after animation has ended in my browser first, after that hovering with a transform worked correctly so now I included it in WOW.

@ryjogo
Copy link
Author

ryjogo commented Mar 18, 2015

Great. Works fine. It's funny becauses that error only shows up in Safari on my system.. Firefox seems figure it all out... thanks for the quick fix!

@ryjogo ryjogo closed this as completed Mar 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants