-
Notifications
You must be signed in to change notification settings - Fork 860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forward and previous channel button does not change application title #1563
Comments
@Dartui Are you able to reproduce the same on v4.7-rc2 https://github.com/mattermost/desktop/releases? |
@amyblais on Xubuntu, Mattermost 4.7-rc2 does not show channel name in application title at all. There is only "Mattermost Desktop App" in title. Later I will try it on Windows installation. |
Windows installation has the same application title, no matter of which channel is selected - Mattermost Desktop App. To be honest I kinda liked seeing what channel I had open, but displaying same title all the time is fixing this issue. |
Linux application also always displays "Mattermost Desktop App", which is way too long for my task manager and ends up hiding notification numbers. Would appreciate a configurable dynamic title -- |
cc @Willyfrog |
we removed using the title from the webapp in 4.7, in 5.0 it will be replaced by something more sensible and useful based on the state of the app.
Can you provide a screenshot? from your description looks more like a WM issue rather than an app issue, but I would like to confirm. |
Good to know, thanks.
I can't currently, because for my sanity, I actually used a binary editor to modify the app.asar fle to change <title>Mattermost Desktop App</title> to <title>Mattermost</title>. (Then I added an HTML comment to soak up the spaces) I hope this suffices:
|
@datn What sort of information would you like to see in the title going forward? |
Thanks for this. Ideally a customizable title, but mainly this: a title should be as short as possible while distinguishing itself from others. I already know it's an app, and I don't need the desktop app distinguished from the mobile app because they run on separate platforms. So "Mattermost" is all that's needed. |
cc @esethna |
@datn makes sense. Are you open to submitting a PR to shorten the title to "Mattermost" instead of "Mattermost Desktop App"? |
I confirm (by marking "x" in the [ ] below: [x]):
Summary
After clicking forward and previous channel buttons, application title does not change and stays the same.
Environment
Steps to reproduce
Expected behavior
Title changing with channel change
Observed behavior
Possible fixes
The text was updated successfully, but these errors were encountered: