Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate --avoid-contracts to --skip #670

Closed
Karrq opened this issue Oct 28, 2024 · 0 comments · Fixed by #702
Closed

Migrate --avoid-contracts to --skip #670

Karrq opened this issue Oct 28, 2024 · 0 comments · Fixed by #702
Labels
compiler 📟 Issues specific to compiling good first issue 🐣 Good for newcomers needs triage ♟️ Issue needs to be picked up or assigned p3 🔵 Indicates low priority item upstream-parity 🟰 Needed for upstream feature parity

Comments

@Karrq
Copy link
Contributor

Karrq commented Oct 28, 2024

Foundry’s 729a76 introduced a setting to avoid compiling some files (skip).

This is the same functionality as our avoid-contracts so we should migrate the functionality or reuse it.
@Karrq Karrq converted this from a draft issue Oct 28, 2024
@Karrq Karrq added good first issue 🐣 Good for newcomers compiler 📟 Issues specific to compiling p3 🔵 Indicates low priority item needs triage ♟️ Issue needs to be picked up or assigned upstream-parity 🟰 Needed for upstream feature parity labels Oct 28, 2024
@dutterbutter dutterbutter changed the title Migrade --avoid-contracts to --skip Migrate --avoid-contracts to --skip Oct 29, 2024
This was referenced Nov 5, 2024
Merged
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in DevEx squad Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler 📟 Issues specific to compiling good first issue 🐣 Good for newcomers needs triage ♟️ Issue needs to be picked up or assigned p3 🔵 Indicates low priority item upstream-parity 🟰 Needed for upstream feature parity
Projects
DevEx squad
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: removes avoid-contracts in favour of --skip matter-labs/foundry-zksync
1 participant
@Karrq