fix: fix eslint errors

fix eslint errors in tests

Author: mattallty

package.json

@@ -4,7 +4,7 @@
   "description": "A full-featured framework for building command line applications (cli) with node.js",
   "main": "index.js",
   "scripts": {
-    "lint": "./node_modules/.bin/eslint lib",
+    "lint": "./node_modules/.bin/eslint lib tests examples",
     "test": "npm run lint && ./node_modules/mocha/bin/mocha --require ./tests/utils/bootstrap.js --full-trace --recursive -R mocha-unfunk-reporter tests/",
     "coverage": "./node_modules/.bin/istanbul cover --include-all-sources true --print both ./node_modules/.bin/_mocha -- --require ./tests/utils/bootstrap.js -R spec --recursive tests/",
     "commit": "git-cz",

tests/caporal-export.js

@@ -1,6 +1,6 @@
 "use strict";
 
-/* global Program, logger, should, makeArgv, sinon */
+/* global Program, should */
 
 describe("require('caporal')", () => {
   it(`should return {new Program()}`, () => {

tests/fatal-error.js

@@ -1,6 +1,6 @@
 "use strict";
 
-/* global Program, logger, should, makeArgv, sinon */
+/* global Program, logger, should, sinon */
 
 const program = new Program();
 

tests/logger.js

@@ -1,6 +1,6 @@
 "use strict";
 
-/* global Program, logger, should, makeArgv, sinon */
+/* global should, sinon */
 
 const myLogger = require('../lib/logger').createLogger();
 const stripColor = require('chalk').stripColor;

tests/no-command.js

@@ -12,11 +12,11 @@ describe('Setting up no command() but an action()', () => {
     .logger(logger)
     .version('1.0.0');
 
-  it(`should execute action()`, (done) => {
-    program.action(() => {
-      done();
-    });
+  it(`should execute action()`, () => {
+    const action = sinon.stub();
+    program.action(action);
     program.parse([]);
+    should(action.callCount).eql(1);
   });
 });
 
@@ -29,11 +29,11 @@ describe('Setting up no command() but an argument() and an action()', () => {
     .version('1.0.0')
     .argument('<foo>', 'My foo arg');
 
-  it(`should execute action()`, (done) => {
-    program.action(() => {
-      done();
-    });
+  it(`should execute action()`, () => {
+    const action = sinon.stub();
+    program.action(action);
     program.parse(makeArgv(['myarg']));
+    should(action.callCount).eql(1);
   });
 });
 

tests/utils/bootstrap.js

@@ -1,8 +1,7 @@
 "use strict";
 
-//const program = global.program = require('../..');
-const Program = global.Program = require('../../lib/program');
-const should = global.should = require('should/as-function');
-const logger = global.logger = require('./callback-logger').logger;
-const makeArgv = global.makeArgv = require('./make-argv');
-const sinon = global.sinon = require('sinon');
+global.Program = require('../../lib/program');
+global.should = require('should/as-function');
+global.logger = require('./callback-logger').logger;
+global.makeArgv = require('./make-argv');
+global.sinon = require('sinon');

tests/verbosity-default.js

@@ -1,6 +1,6 @@
 "use strict";
 
-/* global Program, logger, should, makeArgv, sinon */
+/* global Program, logger, should, makeArgv */
 
 const program = new Program();
 

tests/verbosity-quiet.js

@@ -1,6 +1,6 @@
 "use strict";
 
-/* global Program, logger, should, makeArgv, sinon */
+/* global Program, logger, should, makeArgv */
 
 const program = new Program();
 

tests/verbosity-verbose.js

@@ -1,6 +1,6 @@
 "use strict";
 
-/* global Program, logger, should, makeArgv, sinon */
+/* global Program, logger, should, makeArgv */
 
 const program = new Program();