This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Introduce room v4 which updates event ID format. #5217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 21, 2019
erikjohnston
approved these changes
May 21, 2019
Codecov Report
@@ Coverage Diff @@
## develop #5217 +/- ##
========================================
Coverage 62.48% 62.48%
========================================
Files 338 338
Lines 35035 35035
Branches 5734 5734
========================================
Hits 21890 21890
- Misses 11596 11598 +2
+ Partials 1549 1547 -2 |
I dunno. What's the alternative? that we keep test versions for ever? |
|
[I'm kinda hoping that it will fail somewhat gracefully. I guess i should check...] |
|
#5219 makes the fail better. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will keep this unmerged until matrix-org/matrix-spec-proposals#2002 completes FCP.