You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
@hawkowl says that it should be possible to reuse CertificateOptions for multiple TLS connections, which would be good because creating them is expensive. However, attempting to do so results in the wrong SNI being sent.
It looks like this is because CertificateOptions only uses one OpenSSL context, and ClientTLSOptions sets the set_info_callback on that one context to set the SNI. Obviously if a different ClientTLSOptions changes the callback in the meantime, then it all goes wrong.
(Note that we override ClientTLSOptions to disable cert verification, but it looks the same in the normal twisted impl.)
The text was updated successfully, but these errors were encountered:
@hawkowl says that it should be possible to reuse
CertificateOptions
for multiple TLS connections, which would be good because creating them is expensive. However, attempting to do so results in the wrong SNI being sent.It looks like this is because
CertificateOptions
only uses one OpenSSL context, andClientTLSOptions
sets theset_info_callback
on that one context to set the SNI. Obviously if a different ClientTLSOptions changes the callback in the meantime, then it all goes wrong.(Note that we override ClientTLSOptions to disable cert verification, but it looks the same in the normal twisted impl.)
The text was updated successfully, but these errors were encountered: