This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Implement MSC 1813 - Add room version to make APIs #4447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We also implement `make_membership_event` converting the returned room version to an event format version.
Codecov Report
@@ Coverage Diff @@
## develop #4447 +/- ##
===========================================
+ Coverage 74.77% 74.79% +0.02%
===========================================
Files 336 336
Lines 34023 34031 +8
Branches 5533 5534 +1
===========================================
+ Hits 25439 25454 +15
+ Misses 7014 7004 -10
- Partials 1570 1573 +3 |
This was referenced Jan 23, 2019
richvdh
suggested changes
Jan 24, 2019
synapse/events/__init__.py
Outdated
| int | ||
| """ | ||
| if room_version not in KNOWN_ROOM_VERSIONS: | ||
| raise |
| where origin is the remote homeserver which generated the event. | ||
| Deferred[tuple[str, dict, int]]: resolves to a tuple of | ||
| `(origin, event, event_format)` where origin is the remote | ||
| homeserver which generated the event. |
There was a problem hiding this comment.
could you clarify that event_format is one of the values in synapse.api.constants.EventFormatVersions ?
erikjohnston
force-pushed
the
erikj/msc_1813
branch
from
51d6a93 to
62514bb
Compare
turt2live
added a commit
to matrix-org/matrix-spec-proposals
that referenced
this pull request
Jan 29, 2019
Original proposal: #1813 Implementation proof: matrix-org/synapse#4447 There are no changes from the original proposal.
turt2live
added a commit
to matrix-org/matrix-spec-proposals
that referenced
this pull request
Jan 29, 2019
Original proposal: #1813 Implementation proof: matrix-org/synapse#4447 There are no changes from the original proposal.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We also implement
make_membership_eventconverting the returned on.Based on #4437