This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Add a regression test for logging on failed connections #3912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
approved these changes
Sep 19, 2018
| @@ -0,0 +1 @@ | |||
| Add a regression test for logging failed HTTP requests on Python 3. | |||
There was a problem hiding this comment.
Isn't the important thing in this PR that we fix the logging, rather than adding a test?
There was a problem hiding this comment.
I fixed the logging in another PR (that caused the exception). The logging fix here is just a sneaky b'' showing up fix :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3799