Cannot update room visibility in groups over federation

[turt2live]

Description

This does require a bit of database surgery as I don't think it's possible in the current form of groups. As groups progress, this probably will come up more often.

An admin on another server is unable to modify the room visibility settings of a group.

Steps to reproduce (using riot/develop)

• On homeserver1 create a new group
• Add your homeserver2 user to the group
• Make your homeserver2 user an admin in the group (requires a DB update)
• Add a room to the group
• Using homeserver2, modify the visibility of the room within the group (right hand side -> rooms -> room visibility)
• Observe error

This is probably a synapse bug, but I'm reporting it here for visibility. Here's the synapse errors:

homeserver2 (t2l.io in this case)

2017-12-22 16:57:36,173 - synapse.access.http.8008 - 59 - INFO - PUT-632735- 104.205.135.160 - 8008 - Received request: PUT /_matrix/client/r0/groups/%2Bsupport%3Ahomeserver.today/admin/rooms/!mPYrVomQESEYWWudQw%3Amatrix.org/config/m.visibility?
2017-12-22 16:57:36,188 - synapse.http.outbound - 154 - INFO - PUT-632735- {POST-O-2936765} [homeserver.today] Sending request: POST matrix://homeserver.today/_matrix/federation/v1/groups/+support:homeserver.today/room/!mPYrVomQESEYWWudQw:matrix.org/config/m.visibility?requester_user_id=%40travis%3At2l.io
2017-12-22 16:57:36,196 - synapse.http.outbound - 236 - INFO - PUT-632735- {POST-O-2936765} [homeserver.today] Result: 500 Internal Server Error
2017-12-22 16:57:36,198 - synapse.http.server - 127 - ERROR - PUT-632735- 500: Internal Server Error
Traceback (most recent call last):
  File "/root/.synapse/local/lib/python2.7/site-packages/synapse/http/server.py", line 117, in wrapped_request_handler
    yield request_handler(self, request, request_metrics)
  File "/root/.synapse/local/lib/python2.7/site-packages/twisted/internet/defer.py", line 1384, in _inlineCallbacks
    result = result.throwExceptionIntoGenerator(g)
  File "/root/.synapse/local/lib/python2.7/site-packages/twisted/python/failure.py", line 408, in throwExceptionIntoGenerator
    return g.throw(self.type, self.value, self.tb)
  File "/root/.synapse/local/lib/python2.7/site-packages/synapse/http/server.py", line 263, in _async_render
    callback_return = yield callback(request, **kwargs)
  File "/root/.synapse/local/lib/python2.7/site-packages/twisted/internet/defer.py", line 1384, in _inlineCallbacks
    result = result.throwExceptionIntoGenerator(g)
  File "/root/.synapse/local/lib/python2.7/site-packages/twisted/python/failure.py", line 408, in throwExceptionIntoGenerator
    return g.throw(self.type, self.value, self.tb)
  File "/root/.synapse/local/lib/python2.7/site-packages/synapse/rest/client/v2_alpha/groups.py", line 493, in on_PUT
    group_id, requester_user_id, room_id, config_key, content,
  File "/root/.synapse/local/lib/python2.7/site-packages/twisted/internet/defer.py", line 1384, in _inlineCallbacks
    result = result.throwExceptionIntoGenerator(g)
  File "/root/.synapse/local/lib/python2.7/site-packages/twisted/python/failure.py", line 408, in throwExceptionIntoGenerator
    return g.throw(self.type, self.value, self.tb)
  File "/root/.synapse/local/lib/python2.7/site-packages/synapse/http/matrixfederationclient.py", line 388, in post_json
    ignore_backoff=ignore_backoff,
  File "/root/.synapse/local/lib/python2.7/site-packages/twisted/internet/defer.py", line 1386, in _inlineCallbacks
    result = g.send(result)
  File "/root/.synapse/local/lib/python2.7/site-packages/synapse/http/matrixfederationclient.py", line 247, in _request
    response.code, response.phrase, body
HttpResponseException: 500: Internal Server Error

homeserver1 (homeserver.today in this case)

2017-12-22 16:58:57,340 - synapse.access.https.8558 - 59 - INFO - POST-18650- 10.0.1.2 - 8558 - Received request: POST /_matrix/federation/v1/groups/+support:homeserver.today/room/!mPYrVomQESEYWWudQw:matrix.org/config/m.visibility?requester_user_id=%40travis%3At2l.io
2017-12-22 16:58:57,342 - synapse.federation.transport.server - 140 - INFO - POST-18650- Request from t2l.io
2017-12-22 16:58:57,342 - synapse.http.server - 139 - ERROR - POST-18650- Failed handle request synapse.http.server._async_render on <synapse.federation.transport.server.TransportLayerServer object at 0x7f5f61138090>: <SynapseRequest at 0x7f5f60164950 method=POST uri=/_matrix/federation/v1/groups/+support:homeserver.today/room/!mPYrVomQESEYWWudQw:matrix.org/config/m.visibility?requester_user_id=%40travis%3At2l.io clientproto=HTTP/1.1 site=8558>
Traceback (most recent call last):
  File "/home/matrix/.synapse/local/lib/python2.7/site-packages/synapse/http/server.py", line 116, in wrapped_request_handler
    yield request_handler(self, request, request_metrics)
AttributeError: 'FederationGroupsAddRoomsConfigServlet' object has no attribute 'groups_handler'
2017-12-22 16:58:57,343 - synapse.access.https.8558 - 91 - INFO - POST-18650- 10.0.1.2 - 8558 - {t2l.io} Processed request: 2ms (0ms, 0ms) (0ms/0) 55B 500 "POST /_matrix/federation/v1/groups/+support:homeserver.today/room/!mPYrVomQESEYWWudQw:matrix.org/config/m.visibility?requester_user_id=%40travis%3At2l.io HTTP/1.1" "Synapse/0.25.1"

Version information

Both servers are running 0.25.1 and run in ubuntu containers on the same host.

[clokep]

Communities/groups are being removed, see #11584.