Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Faster Remote Room Joins: Synapse will try to resync from itself. #15123

Open
reivilibre opened this issue Feb 21, 2023 · 1 comment
Open

Faster Remote Room Joins: Synapse will try to resync from itself. #15123

reivilibre opened this issue Feb 21, 2023 · 1 comment
Labels
A-Federated-Join joins over federation generally suck O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@reivilibre
Copy link
Contributor

reivilibre commented Feb 21, 2023

Tested as at v1.78.0rc1.

2023-02-21 15:19:15,209 - synapse.handlers.federation - 1981 - INFO - sync_partial_state_room-24 - Syncing state for room !fuzEIyMtiFYSFEjRCI:libera.chat via matrix.org instead
2023-02-21 15:19:15,209 - synapse.handlers.federation_event - 627 - INFO - sync_partial_state_room-24 - Updating state for $0IdYaOlZVqiCRRb1EF4jXCsxIsE4eW1KPm_etjY8FM4
2023-02-21 15:19:15,750 - synapse.handlers.federation_event - 1068 - INFO - sync_partial_state_room-24-$0IdYaOlZVqiCRRb1EF4jXCsxIsE4eW1KPm_etjY8FM4- - Event $0IdYaOlZVqiCRRb1EF4jXCsxIsE4eW1KPm_etjY8FM4 is missing prev_events ['$-aFRBQqhtO1GtE_mNaZLVm6cCcoQriQANKshvF8ZQaE']: calculating state for a backwards extremity
2023-02-21 15:19:15,751 - synapse.handlers.federation_event - 1098 - INFO - sync_partial_state_room-24-$0IdYaOlZVqiCRRb1EF4jXCsxIsE4eW1KPm_etjY8FM4- - Requesting state after missing prev_event $-aFRBQqhtO1GtE_mNaZLVm6cCcoQriQANKshvF8ZQaE
2023-02-21 15:19:15,752 - synapse.http.federation.well_known_resolver - 253 - INFO - sync_partial_state_room-24-$0IdYaOlZVqiCRRb1EF4jXCsxIsE4eW1KPm_etjY8FM4--$-aFRBQqhtO1GtE_mNaZLVm6cCcoQriQANKshvF8ZQaE--- - Fetching https://matrix.org/.well-known/matrix/server
2023-02-21 15:19:15,937 - synapse.http.federation.well_known_resolver - 190 - INFO - sync_partial_state_room-24-$0IdYaOlZVqiCRRb1EF4jXCsxIsE4eW1KPm_etjY8FM4--$-aFRBQqhtO1GtE_mNaZLVm6cCcoQriQANKshvF8ZQaE--- - Response from .well-known: {'m.server': 'matrix-federation.matrix.org:443'}
2023-02-21 15:19:16,059 - synapse.http.matrixfederationclient - 629 - INFO - sync_partial_state_room-24-$0IdYaOlZVqiCRRb1EF4jXCsxIsE4eW1KPm_etjY8FM4--$-aFRBQqhtO1GtE_mNaZLVm6cCcoQriQANKshvF8ZQaE--- - {GET-O-52239} [matrix.org] Got response headers: 403 Forbidden
2023-02-21 15:19:16,060 - synapse.http.matrixfederationclient - 709 - WARNING - sync_partial_state_room-24-$0IdYaOlZVqiCRRb1EF4jXCsxIsE4eW1KPm_etjY8FM4--$-aFRBQqhtO1GtE_mNaZLVm6cCcoQriQANKshvF8ZQaE--- - {GET-O-52239} [matrix.org] Request failed: GET matrix://matrix.org/_matrix/federation/v1/state_ids/%21fuzEIyMtiFYSFEjRCI%3Alibera.chat?event_id=%24-aFRBQqhtO1GtE_mNaZLVm6cCcoQriQANKshvF8ZQaE: HttpResponseException('403: Forbidden')
2023-02-21 15:19:16,060 - synapse.handlers.federation_event - 1122 - WARNING - sync_partial_state_room-24-$0IdYaOlZVqiCRRb1EF4jXCsxIsE4eW1KPm_etjY8FM4- - Error attempting to resolve state at missing prev_events: 403: Forbidden

Probably a very easy fix: just ignore our own server name in the list of servers to resync from.

Noticed whilst debugging #15115.

@reivilibre reivilibre added A-Federated-Join joins over federation generally suck S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Feb 21, 2023
@DMRobertson
Copy link
Contributor

I guess this is exacerbated by #12801.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Federated-Join joins over federation generally suck O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Development

No branches or pull requests

2 participants