Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

update authlib from 0.15.5 to 1.1.0 #14006

Merged
merged 4 commits into from
Oct 4, 2022
Merged

update authlib from 0.15.5 to 1.1.0 #14006

merged 4 commits into from
Oct 4, 2022

Conversation

ffaex
Copy link
Contributor

@ffaex ffaex commented Oct 1, 2022

There are 2 source files which use the authlib package:

  • synapse/synapse/handlers/oidc.py
  • synapse/synapse/rest/client/login.py

Breaking changes happend in authlib version 1.0.0 https://github.com/lepture/authlib/releases/tag/v1.0.0 .
Imports from authlib which are being used:

  • JsonWebToken, JWTClaims, generate_token, jwt, ClientAuth, OpenIDProviderMetadata, get_well_known_url, CodeIDToken, UserInfo, prepare_grant_uri

None of those seem to be changed in version 1.1.0

this commit fixes #13747

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Pull request includes a sign off
  • Code style is correct
    (run the linters)

Signed-off-by: Fyodor Fomichev [email protected]

@ffaex ffaex requested a review from a team as a code owner October 1, 2022 15:00
@richvdh richvdh changed the title feat: updated authlib from 0.15.5 to 1.1.0 update authlib from 0.15.5 to 1.1.0 Oct 3, 2022
@richvdh
Copy link
Member

richvdh commented Oct 3, 2022

Imports from authlib which are being used:

JsonWebToken, JWTClaims, generate_token, jwt, ClientAuth, OpenIDProviderMetadata, get_well_known_url, CodeIDToken, UserInfo, prepare_grant_uri

This is not a complete list: synapse.rest.client.login has from authlib.jose.errors import BadSignatureError, InvalidClaimError, JoseError. However, I don't think any of these are changing either.

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks plausible to me. If it's not plausible, then we have a problem with the dependency range in pyproject.toml.

@richvdh richvdh enabled auto-merge (squash) October 3, 2022 12:25
@richvdh richvdh merged commit 3e74ad2 into matrix-org:develop Oct 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update authlib to 1.x.x in Debian packages and Docker images
2 participants