Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Remove 'anonymised' from the phone home stats documentation #13321

Merged
merged 7 commits into from
Jul 19, 2022

Conversation

anoadragon453
Copy link
Member

These statistics include the homeserver's server name, so it's confusing to call them "anonymised". They are anonymised in the sense that individual user usage data is not reported, though that may not be as much comfort for those running single-user homeservers.

The feature is opt-in, and this PR drops the "anonymised" wording. It also attempts to spell out what exactly is sent to the reporting endpoint, that one can report stats to their server if they'd like, and how often data is sent.

@anoadragon453 anoadragon453 marked this pull request as ready for review July 19, 2022 10:58
@anoadragon453 anoadragon453 requested a review from a team as a code owner July 19, 2022 10:58
@anoadragon453 anoadragon453 added the X-Release-Blocker Must be resolved before making a release label Jul 19, 2022
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Though we'll want this in 1.63, so you'll need to change the target branch.

Copy link
Member

@clokep clokep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anoadragon453 anoadragon453 changed the base branch from develop to release-v1.63 July 19, 2022 11:57
These statistics include your homeserver's domain name, so it's misleading to call them anonymous.
Individual user data is not reported however, though this may mean little on single-user homeservers.
@anoadragon453 anoadragon453 force-pushed the anoa/homeserver_usage_stats branch from cb66181 to cdd71cb Compare July 19, 2022 12:00
@anoadragon453 anoadragon453 enabled auto-merge (squash) July 19, 2022 12:00
@anoadragon453 anoadragon453 merged commit 6faaf76 into release-v1.63 Jul 19, 2022
@anoadragon453 anoadragon453 deleted the anoa/homeserver_usage_stats branch July 19, 2022 12:38
aaronraimist added a commit to aaronraimist/matrix-docker-ansible-deploy that referenced this pull request Jul 19, 2022
Synapse no longer describes the stats as anonymized since the `server_name` is included.
matrix-org/synapse#13321
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
X-Release-Blocker Must be resolved before making a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants