Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Enable cache time-based expiry by default #11787

Closed
reivilibre opened this issue Jan 20, 2022 · 3 comments · Fixed by #11849
Closed

Enable cache time-based expiry by default #11787

reivilibre opened this issue Jan 20, 2022 · 3 comments · Fixed by #11849
Assignees
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. z-p2 (Deprecated Label)

Comments

@reivilibre
Copy link
Contributor

The 'new' time-based expiry for caches in Synapse seems to have helped out with memory usage (empirically, based on what people are telling me).
It seems like it would be worth enabling by default so that people don't have to know about this obscure option to get the benefits.

Related: #11641 (it's not obvious that even though Synapse's memory usage only grows by default, it is capable of trimming back down).

@DMRobertson
Copy link
Contributor

I'd preach some caution here. We opted out of time-based expiry for a particular cache in #10826. I forget the details (cc @erikjohnston); I'm not sure if we ever convinced ourselves if that change helped?

@anoadragon453 anoadragon453 added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Jan 24, 2022
@anoadragon453
Copy link
Member

I always advise people to do this - enabling it by default would probably help in the majority of cases.

@callahad
Copy link
Contributor

We've been very happy with this on matrix.org for long enough to be confident that this is reasonable to turn on by default.

@callahad callahad added P3 (OBSOLETE: use S- labels.) Approved backlog: not yet scheduled, will accept patches P2 and removed X-Needs-Discussion P3 (OBSOLETE: use S- labels.) Approved backlog: not yet scheduled, will accept patches labels Jan 27, 2022
@kittykat kittykat added the z-p2 (Deprecated Label) label Sep 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. z-p2 (Deprecated Label)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants