From 6df643d08203246bdd8a45f7fb699f9f89acdca0 Mon Sep 17 00:00:00 2001 From: "Olivier Wilkinson (reivilibre)" Date: Thu, 4 Aug 2022 11:00:06 +0100 Subject: [PATCH] Add comment describing why we do not answer make_joins --- synapse/handlers/federation.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/synapse/handlers/federation.py b/synapse/handlers/federation.py index 0cfd561139b4..bff3334c0a41 100644 --- a/synapse/handlers/federation.py +++ b/synapse/handlers/federation.py @@ -752,6 +752,10 @@ async def on_make_join_request( # If our server is still only partially joined, we can't give a complete # response to /make_join, so return a 404 as we would if we weren't in the # room at all. + # The main reason we can't respond properly is that we need to know about + # the auth events for the join event that we would return. + # We should not bother entertaining the make_join since we cannot handle + # the send_join. logger.info( "Rejecting /make_join to %s because it's a partial state room", room_id )