From 2b9f741f3a9dee93e9744774b342c35ce60062c4 Mon Sep 17 00:00:00 2001 From: Richard van der Hoff Date: Sun, 23 Jan 2022 21:08:52 +0000 Subject: [PATCH] Fix logic for dropping old events in fed queue Fixes infinite loops of > logger.info("Invalid prev_events for %s", event_id) --- synapse/storage/databases/main/event_federation.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/synapse/storage/databases/main/event_federation.py b/synapse/storage/databases/main/event_federation.py index 270b30800bf2..a556f17dac15 100644 --- a/synapse/storage/databases/main/event_federation.py +++ b/synapse/storage/databases/main/event_federation.py @@ -1432,7 +1432,10 @@ async def prune_staged_events_in_room( if room_version.event_format == EventFormatVersions.V1: for prev_event_tuple in prev_events: - if not isinstance(prev_event_tuple, list) or len(prev_events) != 2: + if ( + not isinstance(prev_event_tuple, list) + or len(prev_event_tuple) != 2 + ): logger.info("Invalid prev_events for %s", event_id) break