Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redactions should preserve the notifications/invite key on power levels #357

Open
turt2live opened this issue Aug 29, 2018 · 3 comments
Open

Redactions should preserve the notifications/invite key on power levels #357

turt2live opened this issue Aug 29, 2018 · 3 comments
Labels
A-Client-Server Issues affecting the CS API A-S2S Server-to-Server API (federation) enhancement A suggestion for a relatively simple improvement to the protocol room-vNext An idea which will require a bump in room version

Comments

@turt2live
Copy link
Member

Backstory: Notification power levels were added after redactions and hashes were introduced. This results in a protocol version bump being needed to change the redaction rules otherwise hashes would be wrong for servers, making the event fairly conflicted.
@turt2live turt2live added enhancement A suggestion for a relatively simple improvement to the protocol room-vNext An idea which will require a bump in room version labels Aug 29, 2018
@richvdh
Copy link
Member

richvdh commented Jul 14, 2019

Apart from for symmetry with the other power_levels settings, why is it important that redactions do not redact notifications? It doesn't make any difference to the authorization of events in the room (unlike the other power_levels settings: arguably, notification permissions should have gone in a different event type.)

@turt2live
Copy link
Member Author

Because of similar reasons for matrix-org/matrix-spec-proposals#1996 (comment)

Let's keep the argument of convenience vs protocol in one place please.

@richvdh richvdh mentioned this issue Jul 15, 2019
Merged
@richvdh
Copy link
Member

richvdh commented Jul 16, 2019

(discussion now moved to matrix-org/matrix-spec-proposals#2176)

@turt2live turt2live mentioned this issue Jul 16, 2019
Closed
@turt2live turt2live changed the title Redactions should preserve the notifications key on power levels Redactions should preserve the notifications/invite key on power levels Jul 16, 2019
@turt2live turt2live added A-Client-Server Issues affecting the CS API A-S2S Server-to-Server API (federation) labels Jul 16, 2019
@richvdh richvdh transferred this issue from matrix-org/matrix-spec-proposals Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Client-Server Issues affecting the CS API A-S2S Server-to-Server API (federation) enhancement A suggestion for a relatively simple improvement to the protocol room-vNext An idea which will require a bump in room version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@turt2live @richvdh