Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to run tests for installed package #16

Closed
V02460 opened this issue Jan 22, 2022 · 0 comments · Fixed by #23
Closed

Make it easier to run tests for installed package #16

V02460 opened this issue Jan 22, 2022 · 0 comments · Fixed by #23

Comments

@V02460
Copy link
Contributor

V02460 commented Jan 22, 2022

Is your feature request related to a problem? Please describe.
I’m currently packaging this library for Fedora. Building an OS package includes running its tests on the system-installed modules. By having the matrix_common and tests modules in the same folder, the local module will shadow the system-installed one when running the tests. This can lead to false-positive test results.

Describe the solution you'd like
Consider moving matrix_common into a src folder. This way the tests module can be added to the Python path independently of anything else, preventing shadowing when running the tests.

Describe alternatives you've considered
Maintain a downstream workaround by moving/removing files before testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant