From 2297e814bda4fdee1463a2a112ce4f0163cc09e7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=A0imon=20Brandner?= Date: Wed, 17 Nov 2021 14:31:42 +0100 Subject: [PATCH 1/2] Init call feeds with non-muted state MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Šimon Brandner --- src/webrtc/call.ts | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/webrtc/call.ts b/src/webrtc/call.ts index 69897348775..fbc21304072 100644 --- a/src/webrtc/call.ts +++ b/src/webrtc/call.ts @@ -583,8 +583,8 @@ export class MatrixCall extends EventEmitter { new CallFeed({ client: this.client, roomId: this.roomId, - audioMuted: stream.getAudioTracks().length === 0, - videoMuted: stream.getVideoTracks().length === 0, + audioMuted: false, + videoMuted: false, userId, stream, purpose, @@ -822,8 +822,8 @@ export class MatrixCall extends EventEmitter { userId: this.client.getUserId(), stream, purpose: SDPStreamMetadataPurpose.Usermedia, - audioMuted: stream.getAudioTracks().length === 0, - videoMuted: stream.getVideoTracks().length === 0, + audioMuted: false, + videoMuted: false, }); const feeds = [usermediaFeed]; @@ -2063,8 +2063,8 @@ export class MatrixCall extends EventEmitter { userId: this.client.getUserId(), stream, purpose: SDPStreamMetadataPurpose.Usermedia, - audioMuted: stream.getAudioTracks().length === 0, - videoMuted: stream.getVideoTracks().length === 0, + audioMuted: false, + videoMuted: false, }); await this.placeCallWithCallFeeds([callFeed]); } catch (e) { From 2a233ed84c6f80a8c250afdf78c6dafdb52f39f8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=A0imon=20Brandner?= Date: Wed, 17 Nov 2021 14:34:37 +0100 Subject: [PATCH 2/2] Improve CallFeed docs MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Šimon Brandner --- src/webrtc/callFeed.ts | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/webrtc/callFeed.ts b/src/webrtc/callFeed.ts index d2c4ca80f40..02814c14453 100644 --- a/src/webrtc/callFeed.ts +++ b/src/webrtc/callFeed.ts @@ -29,7 +29,13 @@ export interface ICallFeedOpts { userId: string; stream: MediaStream; purpose: SDPStreamMetadataPurpose; + /** + * Whether or not the remote SDPStreamMetadata says audio is muted + */ audioMuted: boolean; + /** + * Whether or not the remote SDPStreamMetadata says video is muted + */ videoMuted: boolean; }