Ensure every route is caught by onError when using the provisioning API #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinbot
approved these changes
Mar 27, 2023
| @@ -236,7 +236,8 @@ export class ProvisioningApi { | |||
| // Pass to error handler. | |||
| next([ex, provisioningRequest]); | |||
| } | |||
| }); | |||
| // Always add an error handler | |||
| }, this.onError); | |||
There was a problem hiding this comment.
Just noting this will supersede any error handling implementation in the sublcass
e.g. https://github.com/matrix-org/matrix-appservice-irc/blob/develop/src/provisioning/Provisioner.ts#L144-L158
(Actually looking again I suppose it wouldn't since that wrapper goes before this error handler?)
I suppose the idea is you would now override onError instead?
There was a problem hiding this comment.
Yeah, that's certainly one way. Or you could wrap your handler in a try/catch and just not emit an error. The onError code was always intended to catch errors that fell through routes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.