Release helper script and CI #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix ref name change the command fetch depth Try checking out the tag Remove tag check Releasey bits Tag file Try fetching all tags Ask it very nicely to fetch tags needs a force to make it happy Finally get tags working fix fails Simpify Correct param Fix name s/file/path Update release script Test publish workflow forgot to checkout test publication Use npm publish Use proper publish script
AndrewFerr
reviewed
Nov 30, 2022
Half-Shot
commented
Nov 30, 2022
| echo "Generated tag $TAG" | ||
|
|
||
| echo "Pushing to origin" | ||
| git push origin $TAG |
There was a problem hiding this comment.
This obviously doesn't allow us to do a PR for releases, which may not be desirable. Thoughts on how this could be re-architected to support that are welcome. Alternatively we can forgo the PR.
There was a problem hiding this comment.
PRs for releases can be a bit of a pain, and are probably redundant since we usually discuss release plans internally before publishing anything. So I'm in favour of forgoing.
AndrewFerr
approved these changes
Dec 8, 2022
| echo "Generated tag $TAG" | ||
|
|
||
| echo "Pushing to origin" | ||
| git push origin $TAG |
There was a problem hiding this comment.
PRs for releases can be a bit of a pain, and are probably redundant since we usually discuss release plans internally before publishing anything. So I'm in favour of forgoing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help people other than me release changes for matrix-appservice-bridge.
This comes in 3 parts:
release.shscript replaces the oldchangelog-release.shscript. It will now generate a draft changelog, check you are happy with it, then create the correct commits, tags and push the right things.