Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slight refactors to provisioner #388

Merged
merged 6 commits into from
Feb 16, 2022
Merged

Slight refactors to provisioner #388

merged 6 commits into from
Feb 16, 2022

Conversation

Half-Shot
Copy link
Contributor

@Half-Shot Half-Shot commented Jan 27, 2022 •
edited
Loading

  • Allow other error types to be thrown, using the interface IApiError
  • Don't require the store to throw an ApiError, instead allow it to return null.
  • Allow userId to be null, as some provisioning paths don't requite a userId (e.g. checking limits on the bridge).

@Half-Shot Half-Shot mentioned this pull request Jan 27, 2022
Closed
jaller94
jaller94 approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@jaller94 jaller94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Half-Shot Half-Shot merged commit 84c2b1a into develop Feb 16, 2022
@Half-Shot Half-Shot mentioned this pull request May 3, 2022
Closed
@jaller94 jaller94 deleted the hs/bridge-widgets branch November 15, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaller94 jaller94 jaller94 approved these changes

Assignees

@Half-Shot Half-Shot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Half-Shot @jaller94