Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify help of matrix_api_calls_failed metric #372

Merged
merged 2 commits into from
Nov 10, 2021

Conversation

jaller94
Copy link
Contributor

@jaller94 jaller94 commented Nov 10, 2021

  • "Count of the number" seems like a duplication to me. Though please keep it if it's not apparent which Prometheus values are a Counter.
  • …_calls_failed had the same help text as …_calls

@jaller94 jaller94 changed the base branch from master to develop November 10, 2021 12:11
@jaller94 jaller94 self-assigned this Nov 10, 2021
@jaller94 jaller94 merged commit b57a3f2 into develop Nov 10, 2021
@jaller94 jaller94 deleted the j94/matrix_api_calls_failed-help branch November 15, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants