Add greedy regex for the bridge namespace #366
Conversation
| regex: "@.+_.+:.*", | ||
| exclusive: true, |
There was a problem hiding this comment.
Exclusive only prevents humans from registering a name with an underscore in their username, right?
Can other appservices still have an exclusive claim on @slack_ or @telegram_?
There was a problem hiding this comment.
Shouldn't matter in this context, only the bridge is going to see this namespace. Synapse will see the "real" namespace from the reg file.
| @@ -639,7 +639,13 @@ export class Bridge { | |||
| url: rawReg.url || undefined, | |||
| protocols: rawReg.protocols || undefined, | |||
| namespaces: { | |||
| users: rawReg.namespaces?.users || [], | |||
| users: [{ | |||
| // Deliberately greedy regex to fix https://github.com/turt2live/matrix-bot-sdk/issues/159 | |||
There was a problem hiding this comment.
"Too many user namespaces registered: expecting exactly one"
Why is it any array then?
Or is it that you may only have one of any "exclusive" value?
namespaces:
aliases: []
users:
- exclusive: false
regex: "@.*:localhost"
- exclusive: true
regex: "@adminbot:localhost"
This works for me locally.. and I don't see an issue with having two claims.
There was a problem hiding this comment.
ah, this is about the bot-sdk only allowing one.
There was a problem hiding this comment.
Yup, this is us basically faking it to the bot-sdk that we have one big namespace to get around the issue.
We don't use the namespace login in the bot-sdk for anything, so this should be safe to do. We don't use this namespace to inform Synapse, so there isn't a risk to security either.
A solution for turt2live/matrix-bot-sdk#159
Hopefully helps solve matrix-org/matrix-appservice-irc#1490