Export matrix-appservice #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaller94
approved these changes
Mar 24, 2021
|
Yeah, and typically this is more useful than asking a developer to add both, as they'll have to effectively keep them in sync each release. It's much easier to export one out of the other. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was actually done a long time ago but got lost when we moved to TS. We have a recurring problem that every time we release a new
matrix-appserviceandmatrix-appservice-bridge, every maintainer must update both projects otherwise Typescript will complain about a version mismatch. Let's avoid developers having to import both versions by just exporting it here.