Add "type" to membership queue metrics #300
Conversation
| @@ -103,7 +103,7 @@ export class MembershipCache { | |||
| return Object.keys(this.membershipMap[roomId]); | |||
| } | |||
| const members = []; | |||
| for (const [userId, [membership, profile]] of Object.entries(this.membershipMap[roomId])) { | |||
There was a problem hiding this comment.
Random linter error I spotted
There was a problem hiding this comment.
Why was this an error?
The value of profile isn't used.
There was a problem hiding this comment.
Well, warning. The linter wasn't happy that profile wasn't used.
There was a problem hiding this comment.
I also read this the commit wrong way, thinking that profile got added.
Nevermind. 🙈
| @@ -103,7 +103,7 @@ export class MembershipCache { | |||
| return Object.keys(this.membershipMap[roomId]); | |||
| } | |||
| const members = []; | |||
| for (const [userId, [membership, profile]] of Object.entries(this.membershipMap[roomId])) { | |||
There was a problem hiding this comment.
Why was this an error?
The value of profile isn't used.
changelog.d/300.bugfix
Outdated
| @@ -0,0 +1 @@ | |||
| Fix a bug that would cause membership queue failures to not be reported as metrics | |||
There was a problem hiding this comment.
- I don't understand what this means. Why are failures reported "as metrics"? Do you mean "as part of the metrics"?
- I also don't understand how adding the label "type" fixes some failures not being reported.
There was a problem hiding this comment.
Update about 2): After having read the issue I found the code where "type" is being used as a label later.
I now understand that this is about handing over all labels on the initial sync of metrics.
There was a problem hiding this comment.
Sorta. Prom-client will get angry if you use a label not defined in the schema. This PR just ensures we define it. Have updated the changelog entry to make it a bit easier to see the bug?
Fixes #297