Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drain the queue after setting up logger #150

Merged
merged 2 commits into from
Jun 26, 2020
Merged

Drain the queue after setting up logger #150

merged 2 commits into from
Jun 26, 2020

Conversation

halkeye
Copy link
Contributor

@halkeye halkeye commented Mar 8, 2020 •
edited
Loading

If you log before loggers are setup, but never actually log to that logger again, it just never logs.

Quick patch to drain the log queue as soon as things are setup.

It also could be done on setLogger

@halkeye
Copy link
Contributor Author

halkeye commented Mar 8, 2020

@Half-Shot it looks like you don't watch the repo, so to be safe gonna ping you as well

@halkeye halkeye force-pushed the drain-after-setup branch from 03a18b2 to 9437bd8 Compare April 16, 2020 17:08
@halkeye
Copy link
Contributor Author

halkeye commented Apr 16, 2020

Rebased and signed

@Half-Shot Half-Shot changed the base branch from master to develop June 26, 2020 09:09
@Half-Shot Half-Shot merged commit 44d1764 into matrix-org:develop Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@halkeye @Half-Shot