Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Adding a gap around panels #447

Closed
synecdokey opened this issue Jan 17, 2024 · 2 comments · Fixed by #454
Closed

Feature request: Adding a gap around panels #447

synecdokey opened this issue Jan 17, 2024 · 2 comments · Fixed by #454
Labels
enhancement New feature or request
Milestone

Comments

@synecdokey
Copy link

I'm trying to get a gap around the panels, and around them, but nothing I've tried seems to work, as the .groupview is position:absolute. Since width and height are managed by dockview, a pure CSS solution seems out of reach, even using margins on the element is impossible.

A small gap property on the dock view would be appreciated, as I don't think CSS can solve it in this case.

What I'd want ideally is something that can look like this, which seems impossible at the moment unless I missed something:
Screenshot 2024-01-17 at 11 02 38 AM

@mathuo
Copy link
Owner

mathuo commented Jan 17, 2024

There is a theme that is shipped with dockview but it's more of an experiment than something that was really intended for use which is similar to what you are describing here.

I did battle with getting a gap to appear on this theme and you can see the CSS code here, it's ok but not great... I do wonder if this could be better achieved though through the library exposing some kind of CSS variable define the gap size, let me have a see what can be done.

Within the docs website you can switch to this theme as below:

image

@mathuo mathuo added the enhancement New feature or request label Jan 17, 2024
@mathuo mathuo linked a pull request Jan 17, 2024 that will close this issue
@mathuo mathuo reopened this Jan 29, 2024
@mathuo mathuo added this to the v1.10.0 milestone Feb 8, 2024
@mathuo
Copy link
Owner

mathuo commented Feb 25, 2024

Released in 1.10.0 https://dockview.dev/

@mathuo mathuo closed this as completed Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants