Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong license.git.copyrightCreationYear when the file has more than 10 commits #151

Closed
brenuart opened this issue Apr 1, 2019 · 4 comments · Fixed by #310
Closed

Wrong license.git.copyrightCreationYear when the file has more than 10 commits #151

brenuart opened this issue Apr 1, 2019 · 4 comments · Fixed by #310
Labels
is:support Support, help or questions stale Inactive items that will be automatically closed if not resurrected
Milestone

Comments

@brenuart
Copy link

brenuart commented Apr 1, 2019

Although it is not yet released, I gave a try to version 3.1 mainly for its GIT creation date feature.

I noticed the RevWalk is configured by default to consider only the last 10 commits. This is causing an issue when computing the creation date of a file that has more than 10 commits in its history. Consequence is the returned date is not the date of the initial commit as expected. Moreover, that date keeps changing as new changes are committed. This case is not catched by the test cases probably because the test repo does not have a file with more than 10 commits in its history.

@ppalaga
Copy link
Contributor

ppalaga commented Apr 1, 2019

Are you sure you do not have just a shallow git clone? I have seen this happening on TravisCI that does a shallow clone by default and the solution was to add git fetch --unshallow to travis.yml.

@brenuart
Copy link
Author

brenuart commented Apr 1, 2019

Not as fair as I know.
Every works fine when I set the property license.git.copyrightLastYearMaxCommitsLookup to a large value (like 10000) to simulate no limit.

@mathieucarbou
Copy link
Owner

@brenuart @ppalaga : I think I will close it: I do not see any way to fix that and there is a workaround, or misconfig here ?

@stale
Copy link

stale bot commented Sep 7, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Inactive items that will be automatically closed if not resurrected label Sep 7, 2021
@mathieucarbou mathieucarbou added the is:support Support, help or questions label Sep 7, 2021
@mathieucarbou mathieucarbou added this to the 4.2 milestone Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:support Support, help or questions stale Inactive items that will be automatically closed if not resurrected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants