fix(decorators): ariaProperty not triggering re-renders from data changes

PiperOrigin-RevId: 469824174

Author: asyncLiz

decorators/aria-property.ts

@@ -47,18 +47,17 @@ export function ariaProperty<E extends ReactiveElement, K extends keyof E&
     set(this: ReactiveElement, value: unknown) {
       // Coerce non-string values to a string
       const strValue = String(value ?? '');
-      const oldValue = this.dataset[property];
-      if (strValue === oldValue) {
-        return;
-      }
-
       if (strValue) {
         this.dataset[property] = strValue;
       } else {
         delete this.dataset[property];
       }
 
-      this.requestUpdate(property, oldValue);
+      // lit will call this setter whenever the data-* attribute changes.
+      // However, this.dataset[property] will automatically be updated to the
+      // current value. To avoid bugs, always request an update regardless of
+      // the old value.
+      this.requestUpdate();
     }
   });
 

decorators/test/aria-property_test.ts

@@ -101,14 +101,4 @@ describe('@ariaProperty', () => {
         .withContext('boolean should coerce to string')
         .toBe('true');
   });
-
-  it('should not request an update if the value stays the same', async () => {
-    const value = 'Aria label';
-    element.ariaLabel = value;
-    await element.updateComplete;
-    element.ariaLabel = value;
-    expect(element.isUpdatePending)
-        .withContext('there should not be an update pending')
-        .toBeFalse();
-  });
 });