This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
fix(infrastructure): support ssr by removing the reference from window #4864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhiomkar
approved these changes
Jun 28, 2019
Codecov Report
@@ Coverage Diff @@
## master #4864 +/- ##
=======================================
Coverage 98.86% 98.86%
=======================================
Files 119 119
Lines 5650 5650
Branches 749 749
=======================================
Hits 5586 5586
Misses 63 63
Partials 1 1Continue to review full report at Codecov.
|
|
All 699 screenshot tests passed for commit c24414c vs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related material-components/material-components-web-react#954
Confirmed that in v2.3.0 of drawer, the output.globalObject referenced
this. In the webpack 4 update, this was changed towindow. To support SSR and ensure that no breaking changes occur during the webpack 4 upgrade, I suggest this change.