This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
fix(menu): Remove code to focus on first/last element on TAB/SHIFT+TAB. #4786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4786 +/- ##
===========================================
- Coverage 98.95% 98.95% -0.01%
===========================================
Files 129 129
Lines 6332 6309 -23
Branches 820 812 -8
===========================================
- Hits 6266 6243 -23
Misses 65 65
Partials 1 1
Continue to review full report at Codecov.
|
abhiomkar
suggested changes
Jun 4, 2019
abhiomkar
approved these changes
Jun 4, 2019
joyzhong
changed the title
|
All 690 screenshot tests passed for commit 7d24ca4 vs. |
abhiomkar
pushed a commit
that referenced
this pull request
Jun 11, 2019
…B. (#4786) Instead, TAB should close the menu and respect default browser tab order. BREAKING CHANGE: The following adapter methods were removed: isFirstElementFocused, isLastElementFocused, focusFirstElement, focusLastElement. The following functionality to handle TAB on menusurface has been removed: "If TAB and last element is focused => Focus on first element", "If SHIFT + TAB and first element is focused => Focus on last element"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, TAB should close the menu and respect default browser tab order.
BREAKING CHANGE: The following adapter methods were removed:
isFirstElementFocused,isLastElementFocused,focusFirstElement,focusLastElement. The following functionality to handle TAB on menusurface has been removed: "If TAB and last element is focused => Focus on first element", "If SHIFT + TAB and first element is focused => Focus on last element"