This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
fix(menu): Use on-surface color for graphic/meta content #4520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhiomkar
approved these changes
Mar 19, 2019
|
It occurs to me that the current state of this PR leads to menu list item text still being on-background but icons are on-surface, which is probably wrong. I'm going to see if I can double-check with design on whether everything should be on-surface. |
|
Update from design: both the icons and text should be on-surface at 87% opacity (high emphasis). |
|
All 627 screenshot tests passed for commit b700402 vs. |
|
All 627 screenshot tests passed for commit 23484a7 vs. |
adrianschmidt
pushed a commit
to Lundalogik/material-components-web
that referenced
this pull request
Mar 29, 2019
…mponents#4520) (cherry picked from commit 74b8d67)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4238 as it pertains to Menu.