This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
fix(ripple): Expose focus/blur handlers #2905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2905 +/- ##
=========================================
+ Coverage 98.3% 98.3% +<.01%
=========================================
Files 101 101
Lines 4359 4363 +4
Branches 563 563
=========================================
+ Hits 4285 4289 +4
Misses 74 74
Continue to review full report at Codecov.
|
kfranqueiro
changed the title
kfranqueiro
suggested changes
Jun 8, 2018
|
Also, it should be feasible to add tests for these 2 new methods, right? |
kfranqueiro
reviewed
Jun 8, 2018
packages/mdc-ripple/README.md
Outdated
| @@ -150,6 +150,8 @@ Method Signature | Description | |||
| `activate() => void` | Proxies to the foundation's `activate` method | |||
| `deactivate() => void` | Proxies to the foundation's `deactivate` method | |||
| `layout() => void` | Proxies to the foundation's `layout` method | |||
| `handleFocus() => void` | Adds `BG_FOCUSED` class to the ripple surface | |||
There was a problem hiding this comment.
I'd genericize these descriptions to simply state that they handle focus / blur events on the ripple surface (see also e.g. Text Field's descriptions of handle methods)
kfranqueiro
approved these changes
Jun 8, 2018
abhiomkar
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds two new public methods to MDC Ripple Foundation - including
handleFocusandhandleBlurto be used by other frameworks on focus and blur.Fixes #2838