This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
fix(line-ripple): Fix CSP inline style rule #2491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2491 +/- ##
==========================================
- Coverage 98.87% 98.87% -0.01%
==========================================
Files 102 102
Lines 4073 4072 -1
Branches 510 510
==========================================
- Hits 4027 4026 -1
Misses 46 46
Continue to review full report at Codecov.
|
kfranqueiro
reviewed
Apr 2, 2018
| `transform-origin: ${xCoordinate}px center`; | ||
|
|
||
| this.adapter_.setAttr('style', attributeString); | ||
| this.adapter_.setStyle('transform-origin', `${xCoordinate}px center`); |
There was a problem hiding this comment.
Does this not need to be transformOrigin to work with element.style[propertyName]?
There was a problem hiding this comment.
Nevermind, I guess either one works, even in IE 11.
kfranqueiro
suggested changes
Apr 2, 2018
packages/mdc-line-ripple/README.md
Outdated
| @@ -64,7 +64,7 @@ Method Signature | Description | |||
| --- | --- | |||
| `addClass(className: string) => void` | Adds a class to the root element | |||
| `removeClass(className: string) => void` | Removes a class from the root element | |||
| `setAttr(attr: string, value: string) => void` | Sets an attribute with a given value on the root element | |||
| `setStyle(propertyName: string, value: string) => void` | Sets the style attribute with a given `propertyName` and `value` on the root element | |||
packages/mdc-line-ripple/adapter.js
Outdated
| @@ -47,11 +47,11 @@ class MDCLineRippleAdapter { | |||
| hasClass(className) {} | |||
|
|
|||
| /** | |||
| * Sets an attribute with a given value on the line ripple element. | |||
| * @param {string} attr | |||
| * Sets the style for a given attribute with a given value on the line ripple element. | |||
kfranqueiro
approved these changes
Apr 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2292