Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

fix(top-app-bar): Remove applyPassive function from toolbar/top app bar #2487

Merged
merged 1 commit into from
Mar 30, 2018
Merged

fix(top-app-bar): Remove applyPassive function from toolbar/top app bar #2487

merged 1 commit into from
Mar 30, 2018

Conversation

williamernest
Copy link
Contributor

Removes applyPassive function from scroll events in top-app-bar and toolbar.

lynnmercier
lynnmercier approved these changes Mar 30, 2018
View reviewed changes
Copy link
Contributor

@lynnmercier lynnmercier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just leave a comment in the PR discussion that the basic scroll event cannot be canceled, so {passive: true} had no effect.

@williamernest williamernest merged commit c252aba into master Mar 30, 2018
@williamernest williamernest deleted the fix/top-app-bar/remove-apply-passive branch March 30, 2018 16:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lynnmercier lynnmercier lynnmercier approved these changes

Assignees

@lynnmercier lynnmercier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@williamernest @lynnmercier