From 6c819a6d68116f56768c52f4074ab296e566c7fa Mon Sep 17 00:00:00 2001 From: Matthew Tylee Atkinson Date: Mon, 29 Oct 2018 00:00:50 +0000 Subject: [PATCH] Fix sidebar options An array (rather than object) was being pushed (introduced in 4e3cf798404b641eeac8541e8f59f2b2274b57bf), which was causing the sidebar options to not be correctly registered, thus they would have no effect. Need to improve the rigour of my QA process :-). --- README.md | 2 ++ package-lock.json | 2 +- package.json | 2 +- src/code/_options.js | 4 ++-- 4 files changed, 6 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index d8d354c8..c33a6065 100644 --- a/README.md +++ b/README.md @@ -213,6 +213,8 @@ This is a fork of the [original landmarks extension](https://github.com/davidtod Changes ------- +- 2.4.2 - 29th of October 2018 + - Fix a bug with sidebar option initialisation. \[[\#213](https://github.com/matatk/landmarks/pull/213)\] - 2.4.1 - 28th of October 2018 - Fix a bug with packaging that was causing the DevTools panel script to be left out of the zip file that gets uploaded to the browser add-on sites (oops again ;-)). \[[\#212](https://github.com/matatk/landmarks/pull/212)\] - 2.4.0 - 28th of October 2018 diff --git a/package-lock.json b/package-lock.json index 103c752e..1975910a 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "landmarks", - "version": "2.4.1", + "version": "2.4.2", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/package.json b/package.json index fb586240..f9ec3a38 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "landmarks", - "version": "2.4.1", + "version": "2.4.2", "private": true, "scripts": { "pre_build": "npm test", diff --git a/src/code/_options.js b/src/code/_options.js index 34f34bf4..d9c2a77d 100644 --- a/src/code/_options.js +++ b/src/code/_options.js @@ -20,12 +20,12 @@ const options = [{ }] if (BROWSER === 'firefox' || BROWSER === 'opera') { - options.push([{ + options.push({ name: 'interface', element: document.getElementById('landmarks-interface'), property: 'value', change: interfaceExplainer - }]) + }) } // Translation