fix: Ignore guessed regions with no innerText #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matatk
force-pushed
the
fix-empty-guessed-regions
branch
from
43f3854 to
16bb660
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a site in the wild with several guessed regions, including
some spurious ones. This addresses some of the issue by ignoring any
region that's essentially empty from the user's perspective. It does not
address regions that are visually hidden, as getComputedStyle() doesn't
cover hidden parent elements. Have decided not to change that for now,
due to the expected performance hit and lack of other examples of false
positives.