Skip to content

Commit

Permalink
Fix bug whereby command descriptions do not appear in help on Firefox…
Browse files Browse the repository at this point in the history
… 66 (#280)

Closes #278
  • Loading branch information
matatk authored Mar 19, 2019
1 parent 48e5aeb commit 0a3b6b2
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 13 deletions.
2 changes: 1 addition & 1 deletion src/assemble/manifest.firefox.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"applications": {
"gecko": {
"id": "[email protected]",
"strict_min_version": "62.0"
"strict_min_version": "66.0"
}
},

Expand Down
15 changes: 3 additions & 12 deletions src/code/_help.js
Original file line number Diff line number Diff line change
Expand Up @@ -96,18 +96,9 @@ function makeHTML(structure, root) {

function addCommandRowAndReportIfMissing(command) {
// Work out the command's friendly name
let action

if (command.name === '_execute_browser_action') {
action = 'Show pop-up'
} else if (BROWSER === 'chrome' || BROWSER === 'opera') {
// Chrome returns the full descriptions
action = command.description
} else {
// Firefox requires the descriptions to be translated
const messageName = command.description.slice(6, -2)
action = browser.i18n.getMessage(messageName)
}
const action = command.name === '_execute_browser_action'
? 'Show pop-up'
: command.description

// Work out the command's shortcut
let shortcutCellElement
Expand Down

0 comments on commit 0a3b6b2

Please sign in to comment.