Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue reading feature calculation adjustment #150

Open
Ayman24x7 opened this issue Jul 4, 2024 · 2 comments
Open

Continue reading feature calculation adjustment #150

Ayman24x7 opened this issue Jul 4, 2024 · 2 comments
Labels
before launch Things to do before v4 launch bug Things that needs to be fixed low priority

Comments

@Ayman24x7
Copy link

The continue reading algorithm? Or whatever, should be (-1 minus one ayah of present at least)

Because I was reading surah kahf, I marked a bookmark and later went to continue using the continue reading button, but it was 1 ayah ahead (it is probably counting the last ayah on display, but it should be 1st Ayah on display or so.)

@marwan marwan added bug Things that needs to be fixed low priority before launch Things to do before v4 launch labels Jul 4, 2024
@Ayman24x7
Copy link
Author

Ayman24x7 commented Aug 14, 2024

This seems to be fixed now. Also the load previous ayah makes the user easier to navigation and adjust with his memory.

Presently, I feel the continue reading is noting current ayah on display minus one or two. Idk how it is calculated. Maybe it is noting a safe limit.

I'm closing this issue as this is not noticeable.or critical for now or other fixes, partly or wholly fixed this issue.

@Ayman24x7
Copy link
Author

I noticed that when you have small ayahs surah. This issue comes back again. The continue reading should calculate 1 or 2 ayah less than the current setting.

Reopening this issue.

(the load previous ayah feature only helps to navigate but that is not real solution.)

@Ayman24x7 Ayman24x7 reopened this Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
before launch Things to do before v4 launch bug Things that needs to be fixed low priority
Projects
None yet
Development

No branches or pull requests

2 participants