-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate use of ffmpeg #114
Comments
Some status update on this:
Still todo:
|
I have a few questions for you @YurySolovyov
|
And
Yes, but I can't estimate how big the impact would be. Need to investigate.
Can you explain a bit? What do you want to achieve? |
a stream sorry*, not a string |
Yes, this is how my demo build worked. Maybe you can sketch up a design you have in mind? I'm curious. |
Here is the list of possible build options, just for the record |
@KeitIG
ATM, with all codecs museeks currently supports, file size is ~1.4Mb |
That's pretty cool |
Did you consider to use upx to pack the binary? |
Electron ships with ffmpg, there might be a way to use this version directly. https://electronjs.org/docs/development/upgrading-chromium#verify-ffmpeg-support |
There might be an issue where chrome only calls ffmpeg for whitelisted formats, so no matter how capable ffmpeg is, chrome might just not pass it through. This is speculation tho. |
Experiments show that it is possible to make a web server that can help us support most of ffmpeg supported audio formats.
This would likely solve most of issues related to lack of native support of different codecs in chrome.
Also ffmpeg provides decent metadata query feature that provides some essential info if available (
loweredMetas
in museeks terms).If we choose to integrate it, everything else is implementation details and I'm sure we can reach consensus there.
So far I know that node module for
ffmpeg
can expose streaming interface for conversion that looks like:Where
path
is filepath andoutputFormat
is extension likewav
ormp3
.From what I can tell, we are interested mostly in
.wav
output format since it is lossless and we won't loose anything from.flac
or mp3. Correct me if I'm wrong.Another thing to consider is binary size: ffmpeg weights something about 30 megs, and I'm not sure how much of this we really need. I tried to reduce file size though build config, but no luck so far. I'm not sure if this is a big issue though.
Thoughts? Questions?
The text was updated successfully, but these errors were encountered: