Add gpg-check to user_install recipe. #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RVM fails on machines with gpg installed. This fix checks for the existence of gpg on the system and imports the appropriate key as defined by the attribute. Use of a ruby_block will allow for some code reuse in the LWRP release.
|
I'm not sure why this test is failing. I don't have a loop as part of my ruby_block. |
|
ping @martinisoft @fnichol |
|
@cmluciano I'm venturing a guess that it is because you are running that resource from within the block started on line 22. Don't have an alternate suggestion at this time though. |
|
I'll go ahead and merge this despite the foodcritic complaint. We can address it later. |
| @@ -26,6 +26,27 @@ | |||
| # if user hash is not a hash (i.e. set to true), init an empty Hash | |||
| opts = Hash.new if opts == true | |||
|
|
|||
| ruby_block 'Conditionally add RVM gpg key' do | |||
There was a problem hiding this comment.
Perhaps try changing this to:
ruby_block "Conditionally add RVM gpg key for #{user}" do
|
Yay it works! |
|
@martinisoft Are you cool with me merging this? |
|
@cmluciano Go for it 👍 |
cmluciano
added a commit
that referenced
this pull request
Mar 6, 2015
Add gpg-check to user_install recipe.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RVM fails on machines with gpg installed. It checks for the
existence of gpg on the system in a ruby_block and imports the . This will allow for some
code reuse for the LWRP release.