Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Add more features to Web Interface #125

Open
damienwolf07 opened this issue Feb 14, 2023 · 4 comments
Open

Suggestion: Add more features to Web Interface #125

damienwolf07 opened this issue Feb 14, 2023 · 4 comments

Comments

@damienwolf07
Copy link

I suggest that we add the ability to forward ports via the web interface and have the ability to scan for Wi-Fi networks via the serial console and web interface. Because the router could be remote and there is probably no way to use the serial console.

I have some knowledge of ESP-IDF and have compiled this firmware many times, All I need is some code to work with and I will probably get it working.

@phucnguyentrong
Copy link
Contributor

phucnguyentrong commented Jul 14, 2024

Hello, I've added portmap feature (forward ports) to the web interface
I've created a pull request here: #167
Feel free to help me on this feature, I'm don't have much experience in C programing :D

I committed my code on this https://github.com/phucnguyentrong/esp32_nat_router , you can check here in case my pull request is not accepted :)

Screenshot:

image

@damienwolf07
Copy link
Author

@phucnguyentrong, Got it!
I have created a pull request on your fork, Try it and see if it works, I will await your feedback ;3

@phucnguyentrong
Copy link
Contributor

@damienwolf07 Thanks, bro. It works like a charm
image

But I have to change some lines of code, from "auto portmethodOK" to "int portmethodOK", etc... Since my compiler seems not understand "auto".
Plus, please don't format code that you don't modify, because it may confuse the reviewer.

Thanks again :)

@damienwolf07
Copy link
Author

damienwolf07 commented Jul 17, 2024

But I have to change some lines of code, from "auto portmethodOK" to "int portmethodOK", etc... Since my compiler seems not understand "auto".

Sorry, I have a fix for that, I didn't have the time for looking what type the parameters were.

Plus, please don't format code that you don't modify, because it may confuse the reviewer.

Yeah, but there is a reason why, the lines were all over the place and it was bothering me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants