Skip to content

Commit ced1ff2

Browse files
authored
Update faiss commit and resolve conflict (opensearch-project#1443)
Signed-off-by: Heemin Kim <[email protected]>
1 parent 06ccdbc commit ced1ff2

20 files changed

+1041
-1083
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -19,4 +19,5 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
1919
### Infrastructure
2020
### Documentation
2121
### Maintenance
22+
* Bump faiss lib commit to 32f0e8cf92cd2275b60364517bb1cce67aa29a55 [#1443](https://github.com/opensearch-project/k-NN/pull/1443)
2223
### Refactoring

jni/CMakeLists.txt

+5-10
Original file line numberDiff line numberDiff line change
@@ -181,17 +181,15 @@ if (${CONFIG_FAISS} STREQUAL ON OR ${CONFIG_ALL} STREQUAL ON OR ${CONFIG_TEST} S
181181
${TARGET_LIB_FAISS} SHARED
182182
${CMAKE_CURRENT_SOURCE_DIR}/src/org_opensearch_knn_jni_FaissService.cpp
183183
${CMAKE_CURRENT_SOURCE_DIR}/src/faiss_wrapper.cpp
184-
${CMAKE_CURRENT_SOURCE_DIR}/src/knn_extension/faiss/utils/BitSet.cpp
185-
${CMAKE_CURRENT_SOURCE_DIR}/src/knn_extension/faiss/MultiVectorResultCollector.cpp
186-
${CMAKE_CURRENT_SOURCE_DIR}/src/knn_extension/faiss/MultiVectorResultCollectorFactory.cpp)
184+
${CMAKE_CURRENT_SOURCE_DIR}/src/faiss_util.cpp
185+
)
187186
target_link_libraries(${TARGET_LIB_FAISS} ${TARGET_LINK_FAISS_LIB} ${TARGET_LIB_COMMON} OpenMP::OpenMP_CXX)
188187
target_include_directories(${TARGET_LIB_FAISS} PRIVATE
189188
${CMAKE_CURRENT_SOURCE_DIR}/include
190-
${CMAKE_CURRENT_SOURCE_DIR}/include/knn_extension/faiss
191-
${CMAKE_CURRENT_SOURCE_DIR}/include/knn_extension/faiss/utils
192189
$ENV{JAVA_HOME}/include
193190
$ENV{JAVA_HOME}/include/${JVM_OS_TYPE}
194-
${CMAKE_CURRENT_SOURCE_DIR}/external/faiss)
191+
${CMAKE_CURRENT_SOURCE_DIR}/external/faiss
192+
)
195193
set_target_properties(${TARGET_LIB_FAISS} PROPERTIES SUFFIX ${LIB_EXT})
196194
set_target_properties(${TARGET_LIB_FAISS} PROPERTIES POSITION_INDEPENDENT_CODE ON)
197195

@@ -228,12 +226,9 @@ if ("${WIN32}" STREQUAL "")
228226
add_executable(
229227
jni_test
230228
tests/faiss_wrapper_test.cpp
229+
tests/faiss_util_test.cpp
231230
tests/nmslib_wrapper_test.cpp
232231
tests/test_util.cpp
233-
tests/knn_extension/faiss/utils/BitSetTest.cpp
234-
tests/knn_extension/faiss/utils/HeapTest.cpp
235-
tests/knn_extension/faiss/MultiVectorResultCollectorTest.cpp
236-
tests/knn_extension/faiss/MultiVectorResultCollectorFactoryTest.cpp
237232
)
238233

239234
target_link_libraries(

jni/include/faiss_util.h

+25
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
// SPDX-License-Identifier: Apache-2.0
2+
//
3+
// The OpenSearch Contributors require contributions made to
4+
// this file be licensed under the Apache-2.0 license or a
5+
// compatible open source license.
6+
//
7+
// Modifications Copyright OpenSearch Contributors. See
8+
// GitHub history for details.
9+
10+
/**
11+
* This file contains util methods which are free of JNI to be used in faiss_wrapper.cpp
12+
*/
13+
14+
#ifndef OPENSEARCH_KNN_FAISS_UTIL_H
15+
#define OPENSEARCH_KNN_FAISS_UTIL_H
16+
17+
#include "faiss/impl/IDGrouper.h"
18+
#include <memory>
19+
20+
namespace faiss_util {
21+
std::unique_ptr<faiss::IDGrouperBitmap> buildIDGrouperBitmap(int *parentIdsArray, int parentIdsLength, std::vector<uint64_t>* bitmap);
22+
};
23+
24+
25+
#endif //OPENSEARCH_KNN_FAISS_UTIL_H

jni/include/knn_extension/faiss/MultiVectorResultCollector.h

-69
This file was deleted.

jni/include/knn_extension/faiss/MultiVectorResultCollectorFactory.h

-26
This file was deleted.

jni/include/knn_extension/faiss/utils/BitSet.h

-54
This file was deleted.

0 commit comments

Comments
 (0)