Unsuccessful end of final blanking process is not logged in text mode

[xambroz]

Hello,
this is more feature request than a bug. The end of the final blanking is not logged for from the log it is not clear whether it finished successfully or whether it has been killed/ended in the middle.
Please could you add some final message to log before exitting like what disk was successfully wiped?

Sample output log:
[2016/08/18 15:41:48] nwipe: notice: Opened entropy source '/dev/urandom'.
[2016/08/18 15:41:48] nwipe: info: Device '/dev/sdb' has sector size 512.
[2016/08/18 15:41:48] nwipe: warning: Changing '/dev/sdb' block size from 4096 to 512.
[2016/08/18 15:41:48] nwipe: info: Device '/dev/sdb' is size 600127266816.
[2016/08/18 15:41:48] nwipe: notice: Invoking method 'PRNG Stream' on device '/dev/sdb'.
[2016/08/18 15:41:48] nwipe: notice: Starting round 1 of 1 on device '/dev/sdb'.
[2016/08/18 15:41:48] nwipe: notice: Starting pass 1 of 1, round 1 of 1, on device '/dev/sdb'.
[2016/08/18 17:02:30] nwipe: notice: 600127266816 bytes written to device '/dev/sdb'.
[2016/08/18 17:02:30] nwipe: notice: Finished pass 1 of 1, round 1 of 1, on device '/dev/sdb'.
[2016/08/18 17:02:30] nwipe: notice: Finished round 1 of 1 on device '/dev/sdb'.
[2016/08/18 17:02:30] nwipe: notice: Blanking device '/dev/sdb'.
<== here it is missing timestamp at 19:00 that the blanking process of the device /dev/sdb disk with SN:0123ABCDEFG finished unsuccessfully

Actually in my particualr case the actual result was exit on signal SIGHUP. Nothing was logged uppon unsuccessfult graceful exit.

Thank you
Michal Ambroz

[martijnvanbrummelen]

Logging has some issue at the moment, I think it would be best to be rewriting or seriously needs too be brushed .

[xambroz]

Actually I consider this to be more feature request rather than bug error.
In my example the cause why the "successfull" end was not logged was that the end was really unsuccessfull. The blanking didn't finished because the nwipe process was really killed with -HUP (due to UPS going down).

So the feature request would be:
It would be nice when nwipe is going down for whatever reason (maskable SIGNAL received, fatal error, exit) to log that it is going down and what is the slate of the erasing processes running.

Thank you
Michal Ambroz

[martijnvanbrummelen]

Will put it on my list.

[PartialVolume]

@xambroz Are you able to confirm this is still an issue, I.e a failed wipe such as a control-C to abort a wipe is not logged with a message saying the wipe had been user aborted and therefore unsuccessful completed ?

There's been a lot of changes since Dec 2017 so want to see if this should be closed or remain open and kept on the radar.

[PartialVolume]

I've assigned this issue to myself. What I propose is a summary box at the end of the log.

Something like this...

#############################
#### /dev/sdc SUCCESS
## operative: PartialVolume (the username of the person doing the erasure)
## /dev/sdc
## Model: WD5000BVT
## Serial No: 568924-fhhy
## Capacity: 500GB
## Wipe Method: Quick erase
## Total number of blocks to Write: xxxxxxxx
## Actual number of blocks written: xxxxxxxx
## Status: SUCCESS or -!!!- FAILURE -!!!-
## If failure then more detail about the failure.
##############################

This is repeated for each disc being wiped.

[PartialVolume]

Proposed text summary here #212 to be implemented in 0.29