Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SC-97] Moving Files from dss-test #1

Merged
merged 7 commits into from
Aug 31, 2023
Merged

[SC-97] Moving Files from dss-test #1

merged 7 commits into from
Aug 31, 2023

Conversation

hexonaut
Copy link
Contributor

@hexonaut hexonaut commented Aug 24, 2023

Moving the cross-chain stuff from https://github.com/makerdao/dss-test/tree/master/src . This trims off all the makerdao-specific stuff and dependencies on configs to simplify dealing with xchain integration testing.

Domain = Chain. Initial support for Optimism and Arbitrum style bridging. Added integration tests for Arbitrum One, Arbitrum Nova, Arbitrum Goerli, Optimism Mainnet, Optimism Goerli, Base and Base Goerli.

@hexonaut hexonaut marked this pull request as ready for review August 24, 2023 17:02
barrutko
barrutko previously approved these changes Aug 29, 2023
Copy link
Contributor

@barrutko barrutko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd consider renaming domain to chain, as it's more of an obvious and self-explanatory name for what it does.
Other than that LGTM.

Copy link
Contributor

@lucas-manuel lucas-manuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes

src/ArbitrumDomain.sol Outdated Show resolved Hide resolved
src/ArbitrumDomain.sol Show resolved Hide resolved
src/OptimismDomain.sol Show resolved Hide resolved
@hexonaut hexonaut merged commit 2ecc323 into master Aug 31, 2023
@hexonaut hexonaut deleted the SC-97-init branch August 31, 2023 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants