Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SC-150] Add Gnosis Chain #5

Merged
merged 15 commits into from
Oct 9, 2023
Merged

[SC-150] Add Gnosis Chain #5

merged 15 commits into from
Oct 9, 2023

Conversation

barrutko
Copy link
Contributor

@barrutko barrutko commented Sep 27, 2023 •
edited
Loading

  • Add bridge executor
  • Add crosschain forwarder
  • Add test suite for the new domain
  • Test functions specific to the newly added contracts

@barrutko barrutko force-pushed the SC-150-add-gnosis-chain branch from daf39e7 to 99524d2 Compare October 5, 2023 03:56
hexonaut
hexonaut previously approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@hexonaut hexonaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lucas-manuel
lucas-manuel requested changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@lucas-manuel lucas-manuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, lets just add a test for the forwarder to ensure that the call to the AMB is being performed as expected using vm.expectCall

@barrutko barrutko merged commit 6f141d8 into master Oct 9, 2023
@barrutko barrutko deleted the SC-150-add-gnosis-chain branch October 9, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hexonaut hexonaut hexonaut approved these changes

@lucas-manuel lucas-manuel lucas-manuel approved these changes

Assignees

@barrutko barrutko

Labels
Priority: High Status: Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barrutko @hexonaut @lucas-manuel