[SC-456] Use generic receivers and upgrade xchain-helpers #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barrutko
previously approved these changes
Jun 11, 2024
lucas-manuel
requested changes
Jun 12, 2024
| function deployCrosschainPayload(IPayload targetPayload, address bridgeReceiver) | ||
| public override returns (IPayload) | ||
| { | ||
| return IPayload(new OptimismCrosschainPayload(targetPayload, bridgeReceiver)); | ||
| } | ||
|
|
||
| function setUp() public { | ||
| hostDomain = new Domain(getChain('mainnet')); | ||
| bridgedDomain = new OptimismDomain(getChain('optimism'), hostDomain); | ||
| bridge = OptimismBridgeTesting.createNativeBridge(getChain('mainnet').createFork(), getChain('optimism').createFork()); | ||
|
|
There was a problem hiding this comment.
Lets apply this formatting change to all createNativeBridge lines just to keep lines shorter
There was a problem hiding this comment.
Suggested change
| bridge = OptimismBridgeTesting.createNativeBridge( | |
| getChain('mainnet').createFork(), | |
| getChain('optimism').createFork() | |
| ); |
|
Coverage after merging SC-456-use-generic-receivers into master will be
Coverage Report
|
|||||||||||||||||||||||||
lucas-manuel
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to the newest xchain-helpers repo, which restructures how bridges are worked with. There is no longer a need for per-chain receivers.